Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add terraform validation docs #313

Merged
merged 5 commits into from
Jul 26, 2024

Conversation

JoshuaGlassKainos
Copy link
Contributor

Jira link (if applicable)

Change description

Add Terraform directory with terraform best practices outlining variable validation that was heavily used in node_os_maintenance window for aks clusters

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@JoshuaGlassKainos JoshuaGlassKainos requested a review from a team as a code owner July 26, 2024 13:47
@JoshuaGlassKainos JoshuaGlassKainos requested review from willwatters, endakelly and ConnorOKane-Kainos and removed request for a team July 26, 2024 13:47

This comment has been minimized.

This comment has been minimized.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

TTLs

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:hmcts/ops-runbooks.git repository
on the add-tf-validation-documentation branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/hmcts/ops-runbooks/actions/runs/10112492657/attempts/1'

🖊️ Please consider adding a word to the allow list if it is flagged as a spelling error but is genuinely used within the project.
🤔 Think we might see a flagged mistake in another PR in the future? Please consider adding it as an expected pattern

@JoshuaGlassKainos JoshuaGlassKainos merged commit daf7f9f into master Jul 26, 2024
3 checks passed
@JoshuaGlassKainos JoshuaGlassKainos deleted the add-tf-validation-documentation branch July 26, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants